Ensure source dirs are absolute #681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfly
force-pushed
the
issue-1942-absolute-paths
branch
from
280d589 to
42882db
Compare
This `COV_CORE_SOURCE` environment variable is key for making sure that child processes continue computing code coverage. However, there's no guarantee that child processes start in the same directory as their parent process, which screws up coverage reporting if you're using relative paths for coverage sources. The fix is to make sure we're dealing with absolute paths. This is a little tricky to get right, because sources can include both dirs and packages. This fixes pytest-dev#465
jfly
force-pushed
the
issue-1942-absolute-paths
branch
from
42882db to
5290b0f
Compare
ionelmc
reviewed
Mar 31, 2025
| # Unfortunately, coverage.py doesn't provide a mechanism | ||
| # for unambiguously specifying source_dirs, so we have to detect if a source is | ||
| # a directory or a package by looking in the filesystem: https://github.com/nedbat/coveragepy/issues/1942. | ||
| os.path.abspath(source) # noqa: PTH100 # see note below for why we're using `os.path.abspath` |
There was a problem hiding this comment.
See https://github.com/pytest-dev/pytest-cov/blob/v6.1.0/src/pytest_cov/engine.py#L120-L121. Happy to remove this if it's no longer applicable.
|
@ionelmc, are we willing to depend on the newly released coveragepy 7.8.0? It includes a new |
|
Yes, why not, try using source_dirs. There will always be older pytest-cov releases for older coveragepy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
COV_CORE_SOURCEenvironment variable is key for making sure that child processes continue computing code coverage. However, there's no guarantee that child processes start in the same directory as their parent process, which screws up coverage reporting if you're using relative paths for coverage sources. The fix is to make sure we're dealing with absolute paths.This is a little tricky to get right, because sources can include both dirs and packages.
This fixes #465.